[U-Boot] [PATCH v3 01/11] ARM: PSCI: change PSCI function IDs base and offsets

[Chen-Yu Tsai]

On Thu, May 19, 2016 at 4:40 PM, Hongbo Zhang <macro.wave.z at gmail.com> wrote:
> On Wed, May 18, 2016 at 5:19 PM, Chen-Yu Tsai <wens at csie.org> wrote:
>> Hi,
>>
>> On Wed, May 18, 2016 at 5:10 PM,  <macro.wave.z at gmail.com> wrote:
>>> From: Wang Dongsheng <dongsheng.wang at nxp.com>
>>>
>>> According to PSCI specification v1.0, the PSCI functions should start from
>>> 0x84000000 for SMC32, this patch changes this base value as well as other
>>> function offset values.
>>
>> I think you should squash this into the PSCI v1.0 skeleton patch. Otherwise
>> between these 2 patches, we get a function ID and version mismatch?
>>
>> ChenYu
>>
>
> Thanks.
> But there won't be the mismatch you mentioned, because in v0.1 the
> function IDs are implementation defined, the can be set to any values,
> here we just make a step forward to adapt legacy v0.1 function IDs
> compatible with the coming v1.0.
>
> This patch is updating legacy ID definitions and the coming v1.0
> skeleton patch is to add new IDs, it is OK to separate them since
> there won't be mismatch you pointed, what's more we've already gotten
> the Reviewed-by: tag  :)

Great! Thanks for the explanation. I'm not that familiar with the PSCI
spec myself.

ChenYu

>>>
>>> Signed-off-by: Wang Dongsheng <dongsheng.wang at nxp.com>
>>> Signed-off-by: Hongbo Zhang <hongbo.zhang at nxp.com>
>>> ---
>>>  arch/arm/include/asm/psci.h | 10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/psci.h b/arch/arm/include/asm/psci.h
>>> index 128a606..a4a19e3 100644
>>> --- a/arch/arm/include/asm/psci.h
>>> +++ b/arch/arm/include/asm/psci.h
>>> @@ -19,13 +19,13 @@
>>>  #define __ARM_PSCI_H__
>>>
>>>  /* PSCI interface */
>>> -#define ARM_PSCI_FN_BASE               0x95c1ba5e
>>> +#define ARM_PSCI_FN_BASE               0x84000000
>>>  #define ARM_PSCI_FN(n)                 (ARM_PSCI_FN_BASE + (n))
>>>
>>> -#define ARM_PSCI_FN_CPU_SUSPEND                ARM_PSCI_FN(0)
>>> -#define ARM_PSCI_FN_CPU_OFF            ARM_PSCI_FN(1)
>>> -#define ARM_PSCI_FN_CPU_ON             ARM_PSCI_FN(2)
>>> -#define ARM_PSCI_FN_MIGRATE            ARM_PSCI_FN(3)
>>> +#define ARM_PSCI_FN_CPU_SUSPEND                ARM_PSCI_FN(1)
>>> +#define ARM_PSCI_FN_CPU_OFF            ARM_PSCI_FN(2)
>>> +#define ARM_PSCI_FN_CPU_ON             ARM_PSCI_FN(3)
>>> +#define ARM_PSCI_FN_MIGRATE            ARM_PSCI_FN(5)
>>>
>>>  #define ARM_PSCI_RET_SUCCESS           0
>>>  #define ARM_PSCI_RET_NI                        (-1)
>>> --
>>> 2.1.4
>>>