[U-Boot] [PATCH v4 11/11] x86: Use binman all x86 boards

[Bin Meng]

Hi Simon,

On Wed, Nov 2, 2016 at 10:07 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 1 November 2016 at 04:07, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Simon,
>>
>> On Fri, Oct 28, 2016 at 10:41 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Bin,
>>>
>>> On 12 October 2016 at 17:56, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> Hi Simon,
>>>>
>>>> On Thu, Oct 13, 2016 at 8:04 AM, Simon Glass <sjg at chromium.org> wrote:
>>>>> Hi Bin,
>>>>>
>>>>> On 6 October 2016 at 14:59, Simon Glass <sjg at chromium.org> wrote:
>>>>>> Change x86 boards to use binman to produce the ROM. This involves adding the
>>>>>> image definition to the device tree and using it in the Makefile. The
>>>>>> existing ifdtool features are no-longer needed.
>>>>>>
>>>>>> Note that the .dtsi file is common and is used for all x86 boards.
>>>>>>
>>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>>>> ---
>>>>>>
>>>>>> Changes in v4:
>>>>>> - Remove RFC tag
>>>>>> - Use binman for all x86 boards
>>>>>>
>>>>>> Changes in v3:
>>>>>> - Put the binman definition in u-boot.dtsi
>>>>>>
>>>>>> Changes in v2:
>>>>>> - Add automated test coverage
>>>>>> - Put the binman definition in a common file for x86
>>>>>> - Various changes and improvements based on using this tool for a while
>>>>>>
>>>>>>  Makefile                 | 45 +++--------------------------------
>>>>>>  arch/x86/dts/u-boot.dtsi | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
>>>>>>  2 files changed, 65 insertions(+), 42 deletions(-)
>>>>>>  create mode 100644 arch/x86/dts/u-boot.dtsi
>>>>>
>>>>> What do you think of this patch?
>>>>>
>>>>
>>>> Sorry, I will try to look at this in a day or two.
>>>
>>> Did you get a chance to take a look at this?
>>>
>>
>> Looks the python import error was caused by an incorrect installation
>> of python. I will try to have a look tomorrow.
>
> OK, that's odd!

I am getting another error with fdtput

fdtput: invalid option -- 'd'
Usage: write a property value to a device tree
        fdtput <options> <dt file> <node> <property> [<value>...]
        fdtput -c <options> <dt file> [<node>...]

The command line arguments are joined together into a single value.
<type>  s=string, i=int, u=unsigned, x=hex
        Optional modifier prefix:
                hh or b=byte, h=2 byte, l=4 byte (default)

My fdtput version is 1.4.0. I suspect I will need to update to latest
version 1.4.2? This tool version requirement should be documented.

Regards,
Bin