[U-Boot] [PATCH v2 6/6] ARMv8: LS1043A: Enable LS1043A default PSCI support

[Hongbo Zhang]

On Wed, Nov 2, 2016 at 10:27 PM, Tom Rini <trini at konsulko.com> wrote:
> On Tue, Nov 01, 2016 at 06:04:32PM +0800, macro.wave.z at gmail.com wrote:
>> From: Hongbo Zhang <hongbo.zhang at nxp.com>
>>
>> A most basic PSCI implementation with only one psci_version is added for
>> LS1043A, this can verify the generic PSCI framework, and more platform specific
>> implementation will be added later.
>>
>> Signed-off-by: Hongbo Zhang <hongbo.zhang at nxp.com>
>> ---
>>  arch/arm/cpu/armv8/Kconfig                       |  3 +++
>>  arch/arm/cpu/armv8/fsl-layerscape/Makefile       |  1 +
>>  arch/arm/cpu/armv8/fsl-layerscape/ls1043a_psci.S | 20 ++++++++++++++++++++
>>  board/freescale/ls1043ardb/Kconfig               |  9 +++++++++
>>  configs/ls1043ardb_defconfig                     |  1 +
>>  5 files changed, 34 insertions(+)
>>  create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1043a_psci.S
>>
>> diff --git a/arch/arm/cpu/armv8/Kconfig b/arch/arm/cpu/armv8/Kconfig
>> index 173950d..985bfca 100644
>> --- a/arch/arm/cpu/armv8/Kconfig
>> +++ b/arch/arm/cpu/armv8/Kconfig
>> @@ -51,6 +51,7 @@ config ARMV8_PSCI
>>  config ARMV8_PSCI_NR_CPUS
>>       int "Maximum supported CPUs for PSCI"
>>       depends on ARMV8_PSCI
>> +     default 4 if TARGET_LS1043ARDB
>>       default 4
>
> Since 4 is the default we don't need to add in a line here.
>
>> @@ -60,6 +61,7 @@ config ARMV8_PSCI_NR_CPUS
>>  config ARMV8_PSCI_CPUS_PER_CLUSTER
>>       int "Number of CPUs per cluster"
>>       depends on ARMV8_PSCI
>> +     default 4 if TARGET_LS1043ARDB
>>       default 0
>>       help
>>         The number of CPUs per cluster, suppose each cluster has same number
>> @@ -72,6 +74,7 @@ if SYS_HAS_ARMV8_SECURE_BASE
>>  config ARMV8_SECURE_BASE
>>       hex "Secure address for PSCI image"
>>       depends on ARMV8_PSCI
>> +     default 0x10010000 if TARGET_LS1043ARDB
>>       help
>>         Address for placing the PSCI text, data and stack sections.
>>         If not defined, the PSCI sections are placed together with the u-boot
>
> I think we should put those of these into the defconfig and once we add
> more targets we can see if there's good reason, and non-TARGET_xxx we
> can key off of to provide default values.
>

I knew when more targets added there will be mess here, I always tried
to follow your suggestion to move these three configs here, and forgot
to use platform defconfig.
Yes I'll move these three configs to our platform defconfig.

> Thanks!
>
> --
> Tom