[U-Boot] [PATCH] gpio: dwapb: Add support for port B

Marek Vasut marex at denx.de
Fri Nov 4 09:34:58 CET 2016


On 11/04/2016 09:09 AM, Phil Edworthy wrote:
> Hi Marek,

Hi,

> On 03 November 2016 17:49, Marek Vasut wrote:
>> On 11/03/2016 02:56 PM, Simon Glass wrote:
>>> On 2 November 2016 at 13:38, Marek Vasut <marex at denx.de
>>> <mailto:marex at denx.de>> wrote:
>>>> On 11/02/2016 04:24 PM, Phil Edworthy wrote:
> <snip>
>> Please no c-structure register definitions, this does not scale :(
> I think this is a long standing issue... For some IP blocks using a
> C-structure for register definitions is painful. On the other hand,
> for some others it may make the code more readable.
> 
> In this case, I would tend to agree with Simon. However, I'll happily
> use whatever you two agree to.

Since the code uses macros, let's not make it inconsistent.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list