[U-Boot] [PATCH v2 2/3] LS1046AQDS: Add NOR Secure Boot Target

[Sumit Garg]

> -----Original Message-----
> From: york sun
> Sent: Monday, November 14, 2016 11:23 PM
> To: Sumit Garg <sumit.garg at nxp.com>; u-boot at lists.denx.de
> Cc: Ruchika Gupta <ruchika.gupta at nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Vini Pillai <vinitha.pillai at nxp.com>
> Subject: Re: [PATCH v2 2/3] LS1046AQDS: Add NOR Secure Boot Target
> 
> On 10/26/2016 03:47 AM, Sumit Garg wrote:
> > Add NOR secure boot target. Also enable sec init.
> >
> > Signed-off-by: Vinitha Pillai <vinitha.pillai at nxp.com>
> > Signed-off-by: Sumit Garg <sumit.garg at nxp.com>
> > ---
> >
> > Changes in v2:
> > Split patches logically from 2 to 3.
> >
> >  board/freescale/ls1046aqds/MAINTAINERS   |  4 ++++
> >  board/freescale/ls1046aqds/ls1046aqds.c  | 18 ++++++++++++++++++
> > configs/ls1046aqds_SECURE_BOOT_defconfig | 29
> > +++++++++++++++++++++++++++++
> >  3 files changed, 51 insertions(+)
> >  create mode 100644 configs/ls1046aqds_SECURE_BOOT_defconfig
> >
> > diff --git a/board/freescale/ls1046aqds/MAINTAINERS
> > b/board/freescale/ls1046aqds/MAINTAINERS
> > index b4549ae..6737d55 100644
> > --- a/board/freescale/ls1046aqds/MAINTAINERS
> > +++ b/board/freescale/ls1046aqds/MAINTAINERS
> > @@ -8,3 +8,7 @@ F:	configs/ls1046aqds_nand_defconfig
> >  F:	configs/ls1046aqds_sdcard_ifc_defconfig
> >  F:	configs/ls1046aqds_sdcard_qspi_defconfig
> >  F:	configs/ls1046aqds_qspi_defconfig
> > +
> > +M:	Sumit Garg <sumit.garg at nxp.com>
> > +S:	Maintained
> > +F:	configs/ls1046aqds_SECURE_BOOT_defconfig
> > diff --git a/board/freescale/ls1046aqds/ls1046aqds.c
> > b/board/freescale/ls1046aqds/ls1046aqds.c
> > index 8c18538..a418590 100644
> > --- a/board/freescale/ls1046aqds/ls1046aqds.c
> > +++ b/board/freescale/ls1046aqds/ls1046aqds.c
> > @@ -20,6 +20,7 @@
> >  #include <fsl_csu.h>
> >  #include <fsl_esdhc.h>
> >  #include <fsl_ifc.h>
> > +#include <fsl_sec.h>
> >  #include <spl.h>
> >
> >  #include "../common/vid.h"
> > @@ -242,6 +243,23 @@ int board_init(void)
> >  	if (adjust_vdd(0))
> >  		printf("Warning: Adjusting core voltage failed.\n");
> >
> > +#ifdef CONFIG_SECURE_BOOT
> > +	/* In case of Secure Boot, the IBR configures the SMMU
> > +	 * to allow only Secure transactions.
> > +	 * SMMU must be reset in bypass mode.
> > +	 * Set the ClientPD bit and Clear the USFCFG Bit
> > +	 */
> 
> Multiple-line comment in wrong format. You just fixed some in your first patch.
> 
> York

Sure I will fix this multi-line comment in next patch-set.

-Sumit