[U-Boot] [PATCH v6 11/21] sf: Remove non-meaningful comments

Siva Durga Prasad Paladugu siva.durga.paladugu at xilinx.com
Wed Nov 16 07:42:18 CET 2016


Hi,

> -----Original Message-----
> From: Jagan Teki [mailto:jagan at openedev.com]
> Sent: Wednesday, November 16, 2016 9:33 AM
> To: u-boot at lists.denx.de
> Cc: Jagan Teki <jagan at openedev.com>; Bin Meng <bmeng.cn at gmail.com>;
> York Sun <york.sun at nxp.com>; Vignesh R <vigneshr at ti.com>; Mugunthan V
> N <mugunthanvnm at ti.com>; Michal Simek <michal.simek at xilinx.com>; Siva
> Durga Prasad Paladugu <sivadur at xilinx.com>
> Subject: [PATCH v6 11/21] sf: Remove non-meaningful comments
> 
> Remove unneeded/non-meaningful commit message on params and flash.
> 
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: York Sun <york.sun at nxp.com>
> Cc: Vignesh R <vigneshr at ti.com>
> Cc: Mugunthan V N <mugunthanvnm at ti.com>
> Cc: Michal Simek <michal.simek at xilinx.com>
> Cc: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> Signed-off-by: Jagan Teki <jagan at openedev.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Jagan Teki <jagan at openedev.com>

Reviewed-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>

Thanks,
Siva
> ---
>  drivers/mtd/spi/sf_params.c | 1 -
>  drivers/mtd/spi/spi_flash.c | 3 ---
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index
> 6157e29..05cedf1 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -42,7 +42,6 @@
>  		.page_size = 256,					\
>  		.flags = (_flags),
> 
> -/* SPI/QSPI flash device params structure */  const struct spi_flash_info
> spi_flash_ids[] = {
>  #ifdef CONFIG_SPI_FLASH_ATMEL		/* ATMEL */
>  	{"AT45DB011D",	   INFO(0x1f2200, 0x0, 64 * 1024,     4,
> SECT_4K) },
> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index
> b126a21..813f08d 100644
> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -1015,16 +1015,13 @@ int spi_flash_scan(struct spi_flash *flash)
>  	    JEDEC_MFR(info) == SPI_FLASH_CFI_MFR_SST)
>  		write_sr(flash, 0);
> 
> -	/* Assign spi data */
>  	flash->name = info->name;
>  	flash->memory_map = spi->memory_map;
>  	flash->dual_flash = spi->option;
> 
> -	/* Assign spi flash flags */
>  	if (info->flags & SST_WR)
>  		flash->flags |= SNOR_F_SST_WR;
> 
> -	/* Assign spi_flash ops */
>  #ifndef CONFIG_DM_SPI_FLASH
>  	flash->write = spi_flash_cmd_write_ops;  #if
> defined(CONFIG_SPI_FLASH_SST)
> --
> 1.9.1



More information about the U-Boot mailing list