[U-Boot] [PATCH v6 21/21] sf: Fix s25fs512s id param table

[Vignesh R]

On Wednesday 16 November 2016 07:17 PM, Jagan Teki wrote:
> On Wed, Nov 16, 2016 at 6:34 PM, Siva Durga Prasad Paladugu
[...]
>>>>> diff --git a/drivers/mtd/spi/spi_flash_ids.c
>>>>> b/drivers/mtd/spi/spi_flash_ids.c index 4ec2255..8f9520f 100644
>>>>> --- a/drivers/mtd/spi/spi_flash_ids.c
>>>>> +++ b/drivers/mtd/spi/spi_flash_ids.c
>>>>> @@ -99,7 +99,7 @@ const struct spi_flash_info spi_flash_ids[] = {
>>>>>       {"s25fl256s_256k", INFO(0x010219, 0x4d00, 256 * 1024,   128,
>>>>> RD_FULL | WR_QPP) },
>>>>>       {"s25fl256s_64k",  INFO(0x010219, 0x4d01,  64 * 1024,   512, RD_FULL
>>>>> | WR_QPP) },
>>>>>       {"s25fs256s_64k",  INFO6(0x010219, 0x4d0181, 64 * 1024, 512,
>>>>> RD_FULL | WR_QPP | SECT_4K) },
>>>>> -     {"s25fs512s",      INFO(0x010220, 0x4d00, 128 * 1024,   512, RD_FULL |
>>>>> WR_QPP) },
>>>>> +     {"s25fs512s",      INFO6(0x010220, 0x4d0081, 128 * 1024,   512,
>>>>> RD_FULL | WR_QPP) },
>>>>
>>>> As I said in my earlier comments, Please add SECT_4K, otherwise it will be
>>> broken.
>>>
>>> If SECT_4K need then it should be an existing issue, but Vignesh R tested this
>>> already. Vignesh any comment?

No, I gave my Tested-by for s25fl512s and not for s25fs series. Before
this patch, s25fl512s was detected as s25fs512s and flash writes used to
fail on s25fl512s.  After this patch, s25fl512s is detected correctly
and flash writes are fine.

>> No, previously, you are disabling 4K sector erase using spansion_s25fss_disable_4KB_erase() routine and
>> making the device as uniform sector size and hence I think no issues previously without 4k erase commands.
>> But now, as you removed it(spansion_s25fss_disable_4KB_erase() ) in 10/21, normal sector erase command may not work on top/bottom sectors with 4k sector size
>> and it may fail now.
> 
> OK, Wait for Vignesh test will update that fix as well.
> 
> thanks!
> 

-- 
Regards
Vignesh