[U-Boot] [PATCH] spl: mmc: fix build without CONFIG_SPL_LIBCOMMON_SUPPORT

Jaehoon Chung jh80.chung at samsung.com
Thu Nov 17 09:09:09 CET 2016


Hi,

On 11/14/2016 06:46 AM, Yann E. MORIN wrote:
> When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement
> is missing a proper statement, which makes the compiler whine.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Pantelis Antoniou <panto at antoniou-consulting.com>
> ---
>  common/spl/spl_mmc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index c674e61..cc81d19 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
>  
>  		break;
>  	case MMCSD_MODE_UNDEFINED:
> +		;
>  #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
>  	default:
>  		puts("spl: mmc: wrong boot mode\n");

case MMCSD_MODE_UNDEFINED:
 ...
#ifdef CONFIG_....
default:
	put()
#endif
	break; 


How about adding "break"?

Best Regards,
Jaehoon Chung

> 



More information about the U-Boot mailing list