[U-Boot] [PATCH] sunxi: add support for Nintendo NES Classic Edition

Jagan Teki jagan at openedev.com
Sat Nov 19 07:38:42 CET 2016


On Fri, Nov 18, 2016 at 5:01 AM, FUKAUMI Naoki <naobsd at gmail.com> wrote:
> Signed-off-by: FUKAUMI Naoki <naobsd at gmail.com>
> ---
>  arch/arm/dts/Makefile                              |  1 +
>  .../dts/sun8i-r16-nintendo-nes-classic-edition.dts | 63 ++++++++++++++++++++++
>  board/sunxi/MAINTAINERS                            |  5 ++
>  configs/Nintendo_NES_Classic_Edition_defconfig     | 24 +++++++++
>  4 files changed, 93 insertions(+)
>  create mode 100644 arch/arm/dts/sun8i-r16-nintendo-nes-classic-edition.dts
>  create mode 100644 configs/Nintendo_NES_Classic_Edition_defconfig
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 932dbe0..660f175 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -255,6 +255,7 @@ dtb-$(CONFIG_MACH_SUN8I_A33) += \
>         sun8i-a33-olinuxino.dtb \
>         sun8i-a33-q8-tablet.dtb \
>         sun8i-a33-sinlinx-sina33.dtb \
> +       sun8i-r16-nintendo-nes-classic-edition.dtb \
>         sun8i-r16-parrot.dtb
>  dtb-$(CONFIG_MACH_SUN8I_A83T) += \
>         sun8i-a83t-allwinner-h8homlet-v2.dtb \
> diff --git a/arch/arm/dts/sun8i-r16-nintendo-nes-classic-edition.dts b/arch/arm/dts/sun8i-r16-nintendo-nes-classic-edition.dts
> new file mode 100644
> index 0000000..dce688e
> --- /dev/null
> +++ b/arch/arm/dts/sun8i-r16-nintendo-nes-classic-edition.dts
> @@ -0,0 +1,63 @@
> +/*
> + * Copyright (c) 2016 FUKAUMI Naoki <naobsd at gmail.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include "sun8i-a33.dtsi"
> +
> +/ {
> +       model = "Nintendo NES Classic Edition";
> +       compatible = "nintendo,nes-classic-edition", "allwinner,sun8i-a33";
> +
> +       aliases {
> +               serial0 = &uart0;
> +       };
> +
> +       chosen {
> +               stdout-path = "serial0:115200n8";
> +       };
> +};
> +
> +&uart0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart0_pins_a>;
> +       status = "okay";
> +};
> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index d7dc55b..e23d45e 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -232,6 +232,11 @@ M: Jelle van der Waa <jelle at vdwaa.nl>
>  S:     Maintained
>  F:     configs/nanopi_neo_defconfig
>
> +NINTENDO NES CLASSIC EDITION BOARD
> +M:     FUKAUMI Naoki <naobsd at gmail.com>
> +S:     Maintained
> +F:     configs/Nintendo_NES_Classic_Edition_defconfig
> +
>  R16 EVB PARROT BOARD
>  M:     Quentin Schulz <quentin.schulz at free-electrons.com>
>  S:     Maintained
> diff --git a/configs/Nintendo_NES_Classic_Edition_defconfig b/configs/Nintendo_NES_Classic_Edition_defconfig
> new file mode 100644
> index 0000000..fcda1be
> --- /dev/null
> +++ b/configs/Nintendo_NES_Classic_Edition_defconfig
> @@ -0,0 +1,24 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +# CONFIG_SPL_MMC_SUPPORT is not set
> +CONFIG_MACH_SUN8I_A33=y
> +CONFIG_DRAM_CLK=600
> +CONFIG_DRAM_ZQ=15291
> +CONFIG_DRAM_ODT_EN=y
> +# CONFIG_MMC is not set
> +CONFIG_USB0_VBUS_DET="AXP0-VBUS-DETECT"
> +CONFIG_AXP_GPIO=y
> +CONFIG_DEFAULT_DEVICE_TREE="sun8i-r16-nintendo-nes-classic-edition"

configs/Nintendo_NES_Classic_Edition_defconfig, any specific reason on
notating capital letters with defconfig name (except this notation
used in existing sunxi defconfigs)? better to use small letters which
is usually follow most of the defconfigs and also add similar name as
dts file name like  sun8i_r16_nintendo_nes_classic-_edition_defconfig

Let me know for any comments?

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.


More information about the U-Boot mailing list