[U-Boot] [PATCHv3 03/15] dm: pci: remove pci_bus_to_hose(0) calling

[Z.Q. Hou]

Hi Simon,

Thanks for your comments!

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2016年11月18日 9:15
> To: Z.Q. Hou <zhiqiang.hou at nxp.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Albert ARIBAUD
> <albert.u.boot at aribaud.net>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Huan Wang-B18965
> <alison.wang at freescale.com>; Sumit Garg <sumit.garg at nxp.com>; Ruchika
> Gupta <ruchika.gupta at nxp.com>; Saksham Jain
> <saksham.jain at nxp.freescale.com>; york sun <york.sun at nxp.com>; M.H. Lian
> <minghuan.lian at nxp.com>; Bin Meng <bmeng.cn at gmail.com>; Mingkai Hu
> <mingkai.hu at nxp.com>
> Subject: Re: [PATCHv3 03/15] dm: pci: remove pci_bus_to_hose(0) calling
> 
> On 16 November 2016 at 02:48, Zhiqiang Hou <Zhiqiang.Hou at nxp.com>
> wrote:
> > From: Minghuan Lian <Minghuan.Lian at nxp.com>
> >
> > There may be multiple PCIe controllers in a SoC.
> > It is not correct that always calling pci_bus_to_hose(0) to get the
> > first PCIe controller for the PCIe device connected other controllers.
> > We just remove this calling because hose always point the correct PCIe
> > controller.
> >
> > Signed-off-by: Minghuan Lian <Minghuan.Lian at nxp.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > ---
> > V3:
> >  - Comment func pci_hose_phys_to_bus() that @hose must be the root PCI
> > controller
> >
> >  drivers/pci/pci_common.c | 17 +++++++----------
> >  1 file changed, 7 insertions(+), 10 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> But please see below
> 
> >
> > diff --git a/drivers/pci/pci_common.c b/drivers/pci/pci_common.c index
> > 1755914..9e09acd 100644
> > --- a/drivers/pci/pci_common.c
> > +++ b/drivers/pci/pci_common.c
> > @@ -181,11 +181,6 @@ phys_addr_t pci_hose_bus_to_phys(struct
> pci_controller *hose,
> >                 return phys_addr;
> >         }
> >
> > -#ifdef CONFIG_DM_PCI
> > -       /* The root controller has the region information */
> > -       hose = pci_bus_to_hose(0);
> > -#endif
> > -
> >         /*
> >          * if PCI_REGION_MEM is set we do a two pass search with
> preference
> >          * on matches that don't have PCI_REGION_SYS_MEMORY set
> @@
> > -236,6 +231,13 @@ int __pci_hose_phys_to_bus(struct pci_controller *hose,
> >         return 1;
> >  }
> >
> > +/*
> > + * pci_hose_phys_to_bus(): Convert physical address to bus address
> > + * @hose:      PCI hose of the root PCI controller
> > + * @phys_addr: physical address to convert
> > + * @flags:     flags of pci regions
> 
> @return ....
> 

Will add the description of return.

Thanks,
Zhiqiang