[U-Boot] [PATCH] ARM: dts: am437x-idk: Fix QSPI compatible string

Jagan Teki jagan at openedev.com
Mon Nov 21 19:03:36 CET 2016


On Mon, Nov 21, 2016 at 10:07 AM, Vignesh R <vigneshr at ti.com> wrote:
> Hi Jagan,
>
> On Thursday 13 October 2016 06:24 PM, Tom Rini wrote:
>> On Thu, Oct 13, 2016 at 05:45:52PM +0530, Jagan Teki wrote:
>>> On Thu, Oct 13, 2016 at 3:53 PM, Vignesh R <vigneshr at ti.com> wrote:
>>>> Unlike Linux kernel, U-Boot depends on "spi-flash" compatible to probe
>>>> m25p80 spi-nor devices. Hence, add "spi-flash" compatible string to
>>>> m25p80 node. Without this patch, flash device DT data is not parsed and
>>>> QSPI operates in unsupported mode leading to data corruption.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>>>
>>> Applied to u-boot-spi/master
>>
>> ... I don't like that we need a non u-boot prefixed string here for the
>> binding to work as that will lead to harder re-syncs later on the dt
>> files.  Why aren't we matching on the existing part?  Thanks!
>>
>
> I don't see this patch in u-boot master yet. If this patch was dropped
> due to Tom's comment above, then could you suggest how to address the issue?

Some how missed this, but do you still unable to probe the flash w/o
"spi-flash"? I think there is a device_probe when !device_active(dev)
that will detect the flash chip. Please try once.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.


More information about the U-Boot mailing list