[U-Boot] flashair and u-boot hooks script

[Stephen Warren]

On 11/22/2016 07:33 AM, Michal Simek wrote:
> On 22.11.2016 15:12, Michal Simek wrote:
>> Hi guys,
>>
>> did you see this problem before?
>>
>> [bin]$ ./u-boot-test-flash xilinx_zynqmp_zcu102  zcu102
>> 192.168.0.103 push:/tmp/tmp.I2MxPKltj7
>> PUSH DIR: /tmp/tmp.I2MxPKltj7
>> ..PUSH FILE: u-boot.bin
>> .... 200
>> [bin]$ ./u-boot-test-flash xilinx_zynqmp_zcu102  zcu102
>> ./flashair.zynqmp: line 42: : No such file or directory
>> [bin]$ ./u-boot-test-flash xilinx_zynqmp_zcu102  zcu102
>> 192.168.0.103 rmlist:/tmp/tmp.UuwcmCDprT push:/tmp/tmp.tmM0rQ89CJ
>> RM LIST: /tmp/tmp.UuwcmCDprT
>> Traceback (most recent call last):
>>   File "/home/monstr/bin/uboot-test-hooks/bin/push-flashair.py", line
>> 118, in <module>
>>     main()
>>   File "/home/monstr/bin/uboot-test-hooks/bin/push-flashair.py", line
>> 115, in main
>>     func(args.host, param)
>>   File "/home/monstr/bin/uboot-test-hooks/bin/push-flashair.py", line
>> 61, in op_rm_list
>>     response = requests.get('http://%s/command.cgi' % host, params)
>> TypeError: get() takes 1 positional argument but 2 were given
>>
>>
>> Pushing files is fine but removing note. Is there any setting which
>> needs to be done on flashair to support removing files?
>
> After playing with this I found that this is fixing it.
> Why - I have no idea. Can you please make a commit message and test this?
>
>  diff --git a/bin/push-flashair.py b/bin/push-flashair.py

>   def op_rm_list(host, rm_list_file):
>       print('RM LIST: ' + rm_list_file)
>       params = {'op': 100, 'DIR': '/'}
>  -    response = requests.get('http://%s/command.cgi' % host, params)
>  +    response = requests.get('http://%s/command.cgi' % host, params=params)

The docs agree with this change, so I've pushed it to the repo. I 
haven't tested it though; I figure your testing is enough given that the 
docs state params should indeed be a keyword argument.