[U-Boot] [PATCH] sata: fix sata command can not being executed bug

Simon Glass sjg at chromium.org
Thu Nov 24 03:20:27 CET 2016


On 20 November 2016 at 19:24,  <yuantian.tang at nxp.com> wrote:
> From: Tang Yuantian <Yuantian.Tang at nxp.com>
>
> Commit d97dc8a0 separated the non-command code into its own file
> which caused variable sata_curr_device can not be set to a correct
> value.
>
> Before commit d97dc8a0, variable sata_curr_device can be set
> correctly in sata_initialize().
> After commit d97dc8a0, sata_initialize() is moved out to its own file.
> Accordingly, variable sata_curr_device is removed from sata_initialize()
> too. This caused sata_curr_device never gets a chance to be set properly
> which prevent other commands from being executed.
>
> This patch sets variable sata_curr_device properly.
>
> Fixes: d97dc8a0 (dm: sata: Separate the non-command code into its
>  own file)
>
> Signed-off-by: Tang Yuantian <yuantian.tang at nxp.com>
> ---
> v3:
>   - refine the commit message
> v2:
>   - refined this patch and updated the commit title and message
>
>  cmd/sata.c    | 9 ++++++---
>  common/sata.c | 8 +++++---
>  2 files changed, 11 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list