[U-Boot] [PATCH v2 6/8] spi: cadence_qspi: Remove returns from end of void functions

[Marek Vasut]

On 11/25/2016 03:38 PM, Phil Edworthy wrote:
> Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>

Nice find :)

Acked-by: Marek Vasut <marek.vasut at gmail.com>

> ---
>  drivers/spi/cadence_qspi_apb.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c
> index e7d8320..1cd636a 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -199,7 +199,6 @@ void cadence_qspi_apb_controller_enable(void *reg_base)
>  	reg = readl(reg_base + CQSPI_REG_CONFIG);
>  	reg |= CQSPI_REG_CONFIG_ENABLE;
>  	writel(reg, reg_base + CQSPI_REG_CONFIG);
> -	return;
>  }
>  
>  void cadence_qspi_apb_controller_disable(void *reg_base)
> @@ -208,7 +207,6 @@ void cadence_qspi_apb_controller_disable(void *reg_base)
>  	reg = readl(reg_base + CQSPI_REG_CONFIG);
>  	reg &= ~CQSPI_REG_CONFIG_ENABLE;
>  	writel(reg, reg_base + CQSPI_REG_CONFIG);
> -	return;
>  }
>  
>  /* Return 1 if idle, otherwise return 0 (busy). */
> @@ -260,7 +258,6 @@ void cadence_qspi_apb_readdata_capture(void *reg_base,
>  	writel(reg, reg_base + CQSPI_REG_RD_DATA_CAPTURE);
>  
>  	cadence_qspi_apb_controller_enable(reg_base);
> -	return;
>  }
>  
>  void cadence_qspi_apb_config_baudrate_div(void *reg_base,
> @@ -292,7 +289,6 @@ void cadence_qspi_apb_config_baudrate_div(void *reg_base,
>  	writel(reg, reg_base + CQSPI_REG_CONFIG);
>  
>  	cadence_qspi_apb_controller_enable(reg_base);
> -	return;
>  }
>  
>  void cadence_qspi_apb_set_clk_mode(void *reg_base,
> @@ -312,7 +308,6 @@ void cadence_qspi_apb_set_clk_mode(void *reg_base,
>  	writel(reg, reg_base + CQSPI_REG_CONFIG);
>  
>  	cadence_qspi_apb_controller_enable(reg_base);
> -	return;
>  }
>  
>  void cadence_qspi_apb_chipselect(void *reg_base,
> @@ -347,7 +342,6 @@ void cadence_qspi_apb_chipselect(void *reg_base,
>  	writel(reg, reg_base + CQSPI_REG_CONFIG);
>  
>  	cadence_qspi_apb_controller_enable(reg_base);
> -	return;
>  }
>  
>  void cadence_qspi_apb_delay(void *reg_base,
> @@ -385,7 +379,6 @@ void cadence_qspi_apb_delay(void *reg_base,
>  	writel(reg, reg_base + CQSPI_REG_DELAY);
>  
>  	cadence_qspi_apb_controller_enable(reg_base);
> -	return;
>  }
>  
>  void cadence_qspi_apb_controller_init(struct cadence_spi_platdata *plat)
> @@ -413,7 +406,6 @@ void cadence_qspi_apb_controller_init(struct cadence_spi_platdata *plat)
>  	writel(0, plat->regbase + CQSPI_REG_IRQMASK);
>  
>  	cadence_qspi_apb_controller_enable(plat->regbase);
> -	return;
>  }
>  
>  static int cadence_qspi_apb_exec_flash_cmd(void *reg_base,
> 


-- 
Best regards,
Marek Vasut