[U-Boot] [PATCH v2 2/4] arm: Remove smdk2410 board

Tom Rini trini at konsulko.com
Sat Nov 26 15:07:09 CET 2016


On Sat, Nov 26, 2016 at 07:30:36PM +0530, Jagan Teki wrote:
> On Sat, Nov 26, 2016 at 7:14 PM, Tom Rini <trini at konsulko.com> wrote:
> > On Sat, Nov 26, 2016 at 07:03:33PM +0530, Jagan Teki wrote:
> >> On Wed, Nov 23, 2016 at 6:31 PM, Simon Glass <sjg at chromium.org> wrote:
> >> > This board has not been converted to DM_SERIAL by the deadline.
> >> > Remove it.
> >> >
> >> > Signed-off-by: Simon Glass <sjg at chromium.org>
> >> > ---
> >>
> >> < snip>
> >>
> >> >  CONFIG_ARCH_SHARK
> >> > -CONFIG_ARCH_SMDK2410
> >>
> >> Code relate to this still there in arch/arm/include/asm/mach-types.h,
> >
> > That's a file we sync(ed) from the kernel and should leave alone, imho.
> 
> I always think that the code related to the CONFIG_* which are listed
> in config_whitelist.txt should be dropped as there is no usage on the
> tree.

Yes, but that's a special case of a file that we should just not touch.

I will however accept the argument that we should re-sync the file with
a generated copy from v4.8 for example but only take the MACH_TYPE_xxx
part and remove all of the machine_is_xxx parts of the file.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161126/3326857c/attachment.sig>


More information about the U-Boot mailing list