[U-Boot] [PATCH v2] rtc: Add RTC chip pcf2127 support

Fabio Estevam festevam at gmail.com
Wed Nov 30 13:42:24 CET 2016


On Wed, Nov 30, 2016 at 5:47 AM, Meng Yi <meng.yi at nxp.com> wrote:

> +       /* write register's data */
> +       if (dm_i2c_write(dev, PCF2127_REG_CTRL1, buf, sizeof(buf)) < 0)
> +               return -1;

Please propagate the error properly:

ret = dm_i2c_write(dev, PCF2127_REG_CTRL1, buf, sizeof(buf));
if (ret)
   return ret;

Same applies in the other places.


More information about the U-Boot mailing list