[U-Boot] [PATCH] libfdt: replace ARCH_FIXUP_FDT with ARCH_FIXUP_FDT_MEMORY

Masahiro Yamada yamada.masahiro at socionext.com
Wed Oct 5 05:27:09 CEST 2016


Hi Simon,

2016-10-05 0:37 GMT+09:00 Simon Glass <sjg at chromium.org>:

>> diff --git a/common/image-fdt.c b/common/image-fdt.c
>> index 3d23608..91970d4 100644
>> --- a/common/image-fdt.c
>> +++ b/common/image-fdt.c
>> @@ -458,6 +458,11 @@ __weak int ft_verify_fdt(void *fdt)
>>         return 1;
>>  }
>>
>> +__weak int arch_fixup_fdt(void *blob)
>> +{
>> +       return 0;
>> +}
>
> Do we have to have a weak function? I was hoping we could avoid these
> since they make it hard to figure out at build time what code is
> executed.
>


This hunk is just reverting Michal's commit e2f88dfd2d9671.

Is it better to add an empty stub to every architecture that may call it?




-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list