[U-Boot] [PATCH] common: env: add kconfig entry for env storage

Heiko Schocher hs at denx.de
Tue Oct 18 07:17:25 CEST 2016


Hello Tom,

Am 18.10.2016 um 00:55 schrieb Tom Rini:
> On Mon, Oct 17, 2016 at 04:17:06PM -0600, Simon Glass wrote:
>> Hi Peng,
>>
>> On 8 October 2016 at 03:06, Peng Fan <peng.fan at nxp.com> wrote:
>>> Add Kconfig entry for ENV storage
>>>
>>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> Cc: Heiko Schocher <hs at denx.de>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>>> Cc: Stefan Roese <sr at denx.de>
>>> Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
>>> Cc: Francois Retief <fgretief at spaceteq.co.za>
>>> ---
>>>   common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 73 insertions(+)
>>>
>>> diff --git a/common/Kconfig b/common/Kconfig
>>> index c69c141..a630924 100644
>>> --- a/common/Kconfig
>>> +++ b/common/Kconfig
>>> @@ -158,6 +158,79 @@ config SPI_BOOT
>>>
>>>   endmenu
>>>
>>> +menu "ENV storage media"
>>> +
>>> +config ENV_IS_IN_DATAFLASH
>>> +       bool "env stored in dataflash"
>>> +       help
>>> +         env stored in dataflash
>>
>> Can you add a little more help detail on this? Also I suspect we
>> should have CONFIG_ENV as well, to enable the actual environment
>> (independent of where it is stored).
>
> Yes, please add a bit more to the text.
>
>> Also, can you migrate the existing configs with moveconfig? That would
>> be a big step forward and may inspire me to move it to linker lists.
>
> Actually, I bet this is going to be messy enough that I'm fine running
> the moveconfig myself right before I merge it in.

Feel free to give me the patch for running the tbot test [1], that the
patch does not change binaries ...

bye,
Heiko

[1] https://github.com/hsdenx/tbot/blob/master/src/tc/uboot/tc_uboot_check_kconfig.py
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list