[U-Boot] [PATCH 1/2] tools: moveconfig: support wildcards in --defconfigs file

Joe Hershberger joe.hershberger at gmail.com
Tue Oct 18 21:25:54 CEST 2016


On Tue, Oct 18, 2016 at 2:23 PM, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Oct 19, 2016 at 01:14:58AM +0900, Masahiro Yamada wrote:
>> 2016-10-17 5:15 GMT+09:00 Tom Rini <trini at konsulko.com>:
>> > On Mon, Oct 17, 2016 at 02:17:22AM +0900, Masahiro Yamada wrote:
>> > I don't see error handling in the case of files (and now globs) not
>> > existing now, is this just handled by other parts of the code?  Thanks!
>>
>>
>> No, it will be removed.
>>
>> With this patch, each line will be a pattern
>> that may match multiple defconfigs,
>> or that may match nothing.
>
> Ah, OK.
>
>> Is it important to check users' possible typos?
>
> Well, will a list of invalid config names say something useful, or fail
> silently or fail in unexpected ways?

It seems like it would be good to warn if a glob (or otherwise)
results in an empty set, because that it probably not what was
intended.

-Joe


More information about the U-Boot mailing list