[U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support

[Stefano Babic]

Hi Jagan,

On 24/10/2016 13:46, Jagan Teki wrote:

>>
>> No, this is not the correct way to do. We should stick with the patches
>> sent to ML and included in patchworks. They are documented and I cannot
>> (that means, all custodians are not allowed) to simply pick up patches
>> from somewhere else.
> 
> True, but I am not saying you to just apply the branch. My intention
> was to check the new changes from your side so-that will send the
> series to ML again.

ok

> 
>>
>> It is enough that we agree about issue and solution. I had already
>> tested with the following patch:
>>
>> diff --git a/configs/imx6qdl_icore_mmc_defconfig
>> b/configs/imx6qdl_icore_mmc_defconfig
>> index 221ea7e..c947e10 100644
>> --- a/configs/imx6qdl_icore_mmc_defconfig
>> +++ b/configs/imx6qdl_icore_mmc_defconfig
>> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb"
>>  CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore"
>>  CONFIG_SYS_PROMPT="icorem6qdl> "
>>  CONFIG_SPL=y
>> +# CONFIG_BLK is not set
>> +# CONFIG_DM_MMC_OPS is not set
>>  CONFIG_BOOTDELAY=3
>>  CONFIG_BOARD_EARLY_INIT_F=y
>>  CONFIG_DISPLAY_CPUINFO=y
>> diff --git a/configs/imx6qdl_icore_nand_defconfig
> 
> nand_defconfig doesn't require this change.
> 

It is what I had expected, but fsl_esdhc is built even in the NAND
configuration. There is omething else enabling (not in defconfig).

In fact, dropping the two lines, I get the error again for
imx6qdl_icore_nand.

The reason is that even if MMC is not set, as far I can see,  these are
automatically set:

CONFIG_DM_MMC=y
CONFIG_DM_MMC_OPS=y

>> b/configs/imx6qdl_icore_nand_defconfig
>> index 8ac3099..55650bb 100644
>> --- a/configs/imx6qdl_icore_nand_defconfig
>> +++ b/configs/imx6qdl_icore_nand_defconfig
>> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb"
>>  CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore"
>>  CONFIG_SYS_PROMPT="icorem6qdl> "
>>  CONFIG_SPL=y
>> +# CONFIG_BLK is not set
>> +# CONFIG_DM_MMC_OPS is not set
>>  CONFIG_BOOTDELAY=3
>>  CONFIG_BOARD_EARLY_INIT_F=y
>>  CONFIG_DISPLAY_CPUINFO=y
> 
> thanks!
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================