[U-Boot] [PATCH V2 6/8] imx: mx6ullevk: support plugin

Peng Fan van.freenix at gmail.com
Wed Sep 28 03:31:23 CEST 2016


Hi Tom,
On Tue, Sep 27, 2016 at 08:46:32PM -0400, Tom Rini wrote:
>On Tue, Sep 27, 2016 at 05:23:25PM +0800, Peng Fan wrote:
>
>> Add plugin code for mx6ullevk.
>> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code.
>
>This isn't the correct thing to say now that it's in Kconfig.

Thanks, I missed to change this.

Stefano, would you mind help change the commit log
to "Define CONFIG_USE_IMXIMG_PLUGIN in defconfig file to use plugin code" 
when you commit this patch?  do you need me to resend a V3?

>
>> 
>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>> Cc: Stefano Babic <sbabic at denx.de>
>> ---
>> 
>> V2:
>>  Drop the makefile changes, because we have plugin supported in arch/arm/imx-common/Makefile.
>> 
>>  board/freescale/mx6ullevk/imximage.cfg |   2 +-
>>  board/freescale/mx6ullevk/plugin.S     | 139 +++++++++++++++++++++++++++++++++
>>  2 files changed, 140 insertions(+), 1 deletion(-)
>>  create mode 100644 board/freescale/mx6ullevk/plugin.S
>> 
>> diff --git a/board/freescale/mx6ullevk/imximage.cfg b/board/freescale/mx6ullevk/imximage.cfg
>> index 4604b62..1a21b49 100644
>> --- a/board/freescale/mx6ullevk/imximage.cfg
>> +++ b/board/freescale/mx6ullevk/imximage.cfg
>> @@ -29,7 +29,7 @@ BOOT_FROM	nor
>>  BOOT_FROM	sd
>>  #endif
>>  
>> -#ifdef CONFIG_USE_PLUGIN
>> +#ifdef CONFIG_USE_IMXIMG_PLUGIN
>
>We don't have this file yet, and shouldn't introduce it with a new
>CONFIG symbol.  So the imx6ullevk series needs to be re-worked to just
>not have this hunk, and we introduce it in this series here.

I missed to drop this when posting out the mx6ull patches,
since they are already in imx next tree, so I worked out this patch set
based on imx-next tree.

Thanks,
Peng.

>
>Looks good otherwise tho.
>
>-- 
>Tom



>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot



More information about the U-Boot mailing list