[U-Boot] [PATCH] mx6sx: Add initial support for UDOO Neo Board

[Breno Matheus Lima]

Hi Andreas,

Thanks for letting me know, I'm going to send a patch to fix it.

2017-01-09 17:30 GMT-02:00 Andreas Färber <afaerber at suse.de>:
>
> Hi,
>
> Am 25.11.2016 um 19:56 schrieb Breno Lima:
> > diff --git a/include/configs/udoo_neo.h b/include/configs/udoo_neo.h
> > new file mode 100644
> > index 0000000..81e0481
> > --- /dev/null
> > +++ b/include/configs/udoo_neo.h
> [...]
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > +     "console=ttymxc0,115200\0" \
> > +     "fdt_high=0xffffffff\0" \
> > +     "initrd_high=0xffffffff\0" \
> > +     "fdt_file=undefined\0" \
> > +     "fdt_addr=0x83000000\0" \
>
> This needs to be fdt_addr_r.
>
> => boot
> switch to partitions #0, OK
> mmc0 is current device
> Scanning mmc 0:1...
> load - load binary file from a filesystem
>
> Usage:
> load <interface> [<dev[:part]> [<addr> [<filename> [bytes [pos]]]]]
>     - Load binary file 'filename' from partition 'part' on device
>        type 'interface' instance 'dev' to address 'addr' in memory.
>       'bytes' gives the size to load in bytes.
>       If 'bytes' is 0 or omitted, the file is read until the end.
>       'pos' gives the file byte position to start reading from.
>       If 'pos' is 0 or omitted, the file is read from the start.
> BOOTP broadcast 1
> ...
>
> > +     "ip_dyn=yes\0" \
> > +     "mmcdev=0\0" \
> > +     "mmcrootfstype=ext4\0" \
> > +     "mmcautodetect=no\0" \
> > +     "findfdt="\
> > +             "if test $board_name = BASIC; then " \
> > +                     "setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; "
\
> > +             "if test $board_name = BASICKS; then " \
> > +                     "setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; "
\
> > +             "if test $board_name = FULL; then " \
> > +                     "setenv fdt_file imx6sx-udoo-neo-full.dtb; fi; " \
> > +             "if test $board_name = EXTENDED; then " \
> > +                     "setenv fdt_file imx6sx-udoo-neo-extended.dtb;
fi; " \
> > +             "if test $fdt_file = UNDEFINED; then " \
> > +                     "echo WARNING: Could not determine dtb to use;
fi; \0" \
>
> Nit: Trailing semicolon and space could be dropped.
>
> > +     "kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
> > +     "pxefile_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
> > +     "ramdisk_addr_r=0x83000000\0" \
> > +     "ramdiskaddr=0x83000000\0" \
>
> Why have a duplicate $ramdiskaddr for a new board?
>
> Regards,
> Andreas
>
> > +     "scriptaddr=" __stringify(CONFIG_LOADADDR) "\0" \
> > +     BOOTENV
> > +
> > +#define BOOT_TARGET_DEVICES(func) \
> > +     func(MMC, mmc, 0)
> > +
> > +#define CONFIG_BOOTCOMMAND \
> > +     "run findfdt; " \
> > +     "run distro_bootcmd"
> > +
> > +#include <config_distro_bootcmd.h>
> [...]
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)


Regards,
--
Breno Matheus Lima