[U-Boot] [PATCH v4 6/16] mtd: ubi: Select RBTREE option from MTD_UBI Kconfig entry

[Maxime Ripard]

On Thu, Jan 26, 2017 at 12:58:56PM +0100, Jagan Teki wrote:
> On Mon, Jan 23, 2017 at 2:46 PM, Maxime Ripard
> <maxime.ripard at free-electrons.com> wrote:
> > From: Boris Brezillon <boris.brezillon at free-electrons.com>
> >
> > Expose the RBTREE feature through Kconfig and select this option from the
> > MTD_UBI option.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > ---
> >  drivers/mtd/ubi/Kconfig | 1 +
> >  lib/Kconfig             | 3 +++
> >  2 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
> > index 0c82395317ab..cb9ba78681ed 100644
> > --- a/drivers/mtd/ubi/Kconfig
> > +++ b/drivers/mtd/ubi/Kconfig
> > @@ -3,6 +3,7 @@ menu "UBI support"
> >  config MTD_UBI
> >         bool "Enable UBI - Unsorted block images"
> >         select CRC32
> > +       select RBTREE if ARCH_SUNXI
> 
> Better to define Kconfig for RBTREE at lib/ and make default there if
> required, this would easy for understanding directory specific Kconfig
> defines as well as showing some help text about RBTREE.

I'm not sure why we'd need to make it a default. This is not optional,
and disabling it will result in a breakage in the UBI code.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170127/634f1007/attachment.sig>