[U-Boot] [U-Boot,RFC,v1] wdt: Add a glue driver for watchdog

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed Jul 5 19:58:58 UTC 2017


On Wed, 2017-07-05 at 21:56 +0200, Heinrich Schuchardt wrote:
> On 07/05/2017 07:45 PM, Andy Shevchenko wrote:

> > This is not a working solution, just an opinion to which direction
> > we might go
> > with ugly broken WDT class.
> > 
> > Feel free to ignore, drop, modify, etc.

^^^^^^ DISCLAIMER

> > +	ret = wdt_reset(wdt);
> > +	if (ret)
> > +		printf("Can't reset watchdog device: %d\n", ret);
> 
> I would suggest debug() instead of printf().
> 
> Imagine this being called from an EFI application in a loop. We
> wouldn't
> want to fill the screen with this message.

Thanks for the indeed correct suggestion, though please read a
disclaimer above. I gave up on that.

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the U-Boot mailing list