[U-Boot] [PATCH 1/5] libfdt.h: Introduce FDT_PATH_MAX

Simon Glass sjg at chromium.org
Fri Jul 7 03:58:26 UTC 2017


Hi,

On 1 July 2017 at 08:01, Marek Vasut <marex at denx.de> wrote:
> On 06/30/2017 06:22 PM, Pantelis Antoniou wrote:
>> Introduce FDT_PATH_MAX
>
> Because ... why ? The commit message is crap, please fix.

A better way of saying this is, please add a motivation to the commit
message :-)

Apart from that:

Reviewed-by: Simon Glass <sjg at chromium.org>

We can just pick it from upstream if it is applied there first.

>
>> Signed-off-by: Pantelis Antoniou <pantelis.antoniou at konsulko.com>
>> ---
>>  lib/libfdt/libfdt.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h
>> index 2f7ebf8..c369015 100644
>> --- a/lib/libfdt/libfdt.h
>> +++ b/lib/libfdt/libfdt.h
>> @@ -100,6 +100,9 @@
>>
>>  #define FDT_ERR_MAX          18
>>
>> +/* Maximum path size of a node (similar to PATH_MAX in *nix) */
>> +#define FDT_PATH_MAX 4096
>> +
>>  /**********************************************************************/
>>  /* Low-level functions (you probably don't need these)                */
>>  /**********************************************************************/
>>
>
>
> --
> Best regards,
> Marek Vasut

Regards,
Simon


More information about the U-Boot mailing list