[U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code

Simon Glass sjg at chromium.org
Sat Jun 17 03:41:21 UTC 2017


+Tom

On 13 June 2017 at 01:06, Lothar Waßmann <LW at karo-electronics.de> wrote:
> Hi,
>
> On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
>> On 8 June 2017 at 02:16, Lothar Waßmann <LW at karo-electronics.de> wrote:
>> > Create exception stack in IRAM if available to facilitate debugging of
>> > pre-relocation code by catching exceptions rather than stopping dead.
>> >
>> > Signed-off-by: Lothar Waßmann <LW at KARO-electronics.de>
>> > ---
>> >  arch/arm/lib/vectors.S | 5 ++++-
>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> But please see below.
>>
>> >
>> > diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
>> > index f53b1e9..1019091 100644
>> > --- a/arch/arm/lib/vectors.S
>> > +++ b/arch/arm/lib/vectors.S
>> > @@ -117,7 +117,6 @@ data_abort:
>> >  not_used:
>> >  irq:
>> >  fiq:
>> > -
>>
>> What is this?
>>
> Ooops. An unintentionally deleted empty line.
> Should I resend the patch, or can you fix it up when applying?

Probably the latter, but it's up to the custodian.


More information about the U-Boot mailing list