[U-Boot] [PATCH 4/5] treewide: convert assert() to BUG_ON()

Simon Glass sjg at chromium.org
Wed Nov 29 13:08:18 UTC 2017


Hi Masahiro,

On 28 November 2017 at 05:23, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> We do not need multiple ways to do the same thing.  Instead of
> assert(), use BUG_ON() from Linux.  The logic is opposite, but
> Coccinelle is of great help for such a conversion.  We could
> simply convert assert(x) to BUG_ON(!x) for all expressions "x",
> but I did a bit better job by converting assert(a == b) to
> BUG_ON(a != b), etc.

My reading of BUG_ON() is that it does not compile to nothing when
DEBUG is not set, unlike assert(). So they do not seem to be
equivalent.

Regards,
Simon


More information about the U-Boot mailing list