[U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

[Alexander Graf]

On 04.10.17 18:39, Rob Clark wrote:
> On Wed, Oct 4, 2017 at 12:29 PM, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> On 10/04/2017 05:25 PM, Alexander Graf wrote:
>>>
>>>
>>> On 04.10.17 16:57, Rob Clark wrote:
>>>> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt
>>>> <xypron.glpk at gmx.de> wrote:
>>>>> On 10/04/2017 04:14 PM, Rob Clark wrote:
>>>>>> On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt
>>>>>> <xypron.glpk at gmx.de> wrote:
>>>>>>> Queued and signaled describe boolean states of events.
>>>>>>> So let's use type bool and rename the structure members to is_queued
>>>>>>> and is_signaled.
>>>>>>>
>>>>>>> Update the comments for is_queued and is_signaled.
>>>>>>
>>>>>> Reviewed-by: Rob Clark <robdclark at gmail.com>
>>>>>>
>>>>>> It would be kinda nice to merge my efi_event fixes and rework to use
>>>>>> an arbitrary sized list of events before making too many more
>>>>>> efi_event changes, since that is kind of annoying to keep rebasing ;-)
>>>>>>
>>>>>> BR,
>>>>>> -R
>>>>>
>>>>> I would not mind if you patch went first.
>>>>>
>>>>> But your patch
>>>>> https://patchwork.ozlabs.org/patch/812967/
>>>>> is not applicable to U-Boot master and needs rebasing anyway.
>>>>
>>>> jfyi, I have it (and other pending patches) rebased on latest master
>>>> (as of ~yesterday) here:
>>>>
>>>>     https://github.com/robclark/u-boot/commits/wip-enough-uefi-for-shell
>>>>
>>>> I wasn't planning on resending until I get further with FAT write
>>>> stuff (currently on a local branch, although I might not get much time
>>>> to work on in the next week or two).. although I can re-send it or any
>>>> of the other patches to get Shell.efi working if wanted.  (Note that
>>>> I'm also using your patch for efi watchdog support, that was one of
>>>> the other required bits.)
>>>>
>>>> Not sure what agraf's plan is but I think the needed bits for
>>>> Shell.efi are mergable already.
>>>
>>> I don't have a concrete plan - in general I consider patches that have
>>> unaddressed review comments as "not to be applied atm" though and I'm
>>> not sure I have anything pending from you that would not fall into that
>>> category :).
>>>
>>> Can you split off a series that has Heinrich's blessing to get us as far
>>> as we can, so we can keep your queue short?
>>>
>>
>> These are the two first patches in Rob's queue:
>>
>> efi_loader: support 16 protocols per efi_object
>> https://patchwork.ozlabs.org/patch/806167/
>>
>> efi_loader: allow creating new handles
>> https://patchwork.ozlabs.org/patch/806173/
> 
> btw, you can add for these two:
> 
> Reviewed-by: Rob Clark <robdclark at gmail.com>

I usually apply patches using patchwork which gives me tags that were 
emailed directly onto the mail thread integrated into the mbox I download.

In other words, if you reply to the patch with a reviewed-by tag, I'll 
automatically have it when applying the patch. If you mention it in an 
email somewhere chances are quite good it slips through the cracks :)

(and yes, I've added those two manually now)


Alex