[U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

[Rob Clark]

On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf <agraf at suse.de> wrote:
>
>
>> Am 08.10.2017 um 17:54 schrieb Rob Clark <robdclark at gmail.com>:
>>
>>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent
>>> comment Simon remarked that types should not be uppercase. So I was
>>> planning to replace all occurences of UINTN by size_t in an upcoming patch.
>>
>> btw, how would you feed about:
>>
>> typedef size_t efi_uintn_t;
>>
>> instead of using size_t directly?  UINTN is used in a bunch of places
>> where size_t, although it might be the right size, does not feel
>> appropriate..
>
> I like the idea :)
>

btw, 2nd benefit that I didn't immediately think of.. but if I'm
comparing UEFI spec and edk2 headers, if I see size_t in u-boot's
headers but UINTN in UEFI spec / edk2, then I have to stop and think
and remember how UINTN is defined in the spec.  If I see efi_uintn_t,
I don't ;-)

I'll convert the efi_loader patches for Shell.efi to
efi_uintn_t/efi_intn_t.. we can handle the rest of conversion and
removal of UINTN as a follow-on patch, imho.

BR,
-R