[U-Boot] [PATCH 1/6] mx6sabresd: Avoid calling setup_display() from SPL code

[Stefano Babic]

On 23/09/2017 04:45, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> There is no need call setup_display() from SPL code, so move it to
> board_init(), which executes only in U-Boot proper.
> 
> Reported-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index 5b50bc8..f14b759 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -620,9 +620,6 @@ int board_ehci_power(int port, int on)
>  int board_early_init_f(void)
>  {
>  	setup_iomux_uart();
> -#if defined(CONFIG_VIDEO_IPUV3)
> -	setup_display();
> -#endif
>  
>  	return 0;
>  }
> @@ -639,6 +636,9 @@ int board_init(void)
>  		setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6q_i2c_pad_info1);
>  	else
>  		setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c_pad_info1);
> +#if defined(CONFIG_VIDEO_IPUV3)
> +	setup_display();
> +#endif
>  #ifdef CONFIG_USB_EHCI_MX6
>  	setup_usb();
>  #endif
> 


Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================