[U-Boot] [PATCH 2/2] spi: kirkwood: Full dm conversion

[Chris Packham]

On Fri, Apr 27, 2018 at 5:44 PM Stefan Roese <sr at denx.de> wrote:

> Hi Chris,

> On 27.04.2018 00:45, Chris Packham wrote:
> > On 26/04/18 18:00, Jagan Teki wrote:
> >> On Thu, Mar 15, 2018 at 5:03 PM, Jagan Teki
> <jagan at amarulasolutions.com>
wrote:
> >>> kirkwood now support dt along with platform data,
> >>> respective boards need to switch into dm for the same.
> >>
> >> Added all board mainatiner, using this driver on their relevant
> >> boards. So try to switch to DM_SPI(SPI_FLASH) before migration
> >> deadline expires.
> >>
> >> Jagan.
> >
> > Hopefully I can get to db88f6820-amc next week.
> >
> > Stefan, did you want me to send a patch for db88f6820-gp at the same
> > time since the amc board is derived from it?

> Sure, that would be helpful.

> But I'm a little bit puzzled about this DM conversion for MVEBU
> platforms. As all MVEBU targets are already using DM and DM_SPI:

> arch/arm/Kconfig:

> ...
> config ARCH_MVEBU
>           bool "Marvell MVEBU family (Armada XP/375/38x/3700/7K/8K)"
>           select OF_CONTROL
>           select OF_SEPARATE
>           select DM
>           select DM_ETH
>           select DM_SERIAL
>           select DM_SPI
>           select DM_SPI_FLASH

> So there should be no need to change something here. Or is something
> not working correctly on some of the MVEBU platforms?

> What really is missing is the conversion of the older Marvell
> platforms, like Kirkwood and Orion. Those are quite ancient and
> have no DM / OF / DT support at all (AFAIR). So here is the real
> work that needs to be done. Or all those boards might get dropped
> soon.

Yeah sure enough

=> dm tree
  Class      Probed  Driver      Name
----------------------------------------
  root       [ + ]   root_drive  root_driver
  simple_bus [ + ]   generic_si  `-- soc
  simple_bus [ + ]   generic_si      `-- internal-regs
  spi        [ + ]   mvebu_spi           |-- spi at 10680
  spi_flash  [   ]   spi_flash_          |   `-- spi-flash at 0
  i2c        [   ]   i2c_mvtwsi          |-- i2c at 11000
  serial     [ + ]   ns16550_se          |-- serial at 12000
  eth        [ + ]   mvneta              |-- ethernet at 34000
  usb        [   ]   ehci_mvebu          |-- usb at 58000
  eth        [ + ]   mvneta              `-- ethernet at 70000

So nothing to do for MVEBU.

I do have a passing interest in keeping kirkwood support but lack an
upstream supported platform to use. I'll have to see if I can update one of
our boards to use and upstream bootloader.