[U-Boot] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

Max Filippov jcmvbkbc at gmail.com
Mon Feb 12 21:48:53 UTC 2018


On Mon, Feb 12, 2018 at 1:03 PM, Tom Rini <trini at konsulko.com> wrote:
>> On Mon, Feb 12, 2018 at 6:23 AM, Tom Rini <trini at konsulko.com> wrote:
>> > I'm largely ok with the above, but:
>> > - For Xtensa (Max?), CONFIG_SYS_TEXT_ADDR needs to be renamed to
>> >   CONFIG_SYS_TEXT_BASE there
>>
>> For xtensa that address is defined as an expression, like
>> (CONFIG_SYS_MEMORY_TOP - CONFIG_SYS_MONITOR_LEN),
>> and for a single board it may vary with the CPU core on that board.
>
> OK.  But are those also really dynamic values?  SYS_MEMORY_TOP,
> SYS_MONITOR_LEN and SYS_TEXT_ADDR need to be converted to Kconfig, or
> removed from CONFIG namespace, whatever makes the most sense.  If the

At least two of the three -- yes, in a sense that they cannot be calculated
without the core-specific configuration overlay.
I'll move SYS_MONITOR_LEN to the Kconfig and move SYS_MEMORY_TOP
and SYS_TEXT_ADDR from the CONFIG namespace.

> notion of CONFIG_SYS_TEXT_BASE is just pointless to Xtensa, we add them
> to the ifneq(...,) test for the change Alexey is doing.  Thanks!

Yes, please.

-- 
Thanks.
-- Max


More information about the U-Boot mailing list