[U-Boot] [PATCH v2 5/5] cmd: Add osd commands

Simon Glass sjg at chromium.org
Wed May 23 16:33:46 UTC 2018


Hi Mario,

On 23 May 2018 at 06:09, Mario Six <mario.six at gdsys.cc> wrote:
> Add command to query information from and write text to on-screen
> display (OSD) devices.
>
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>
> ---
>
> v1 -> v2:
> * Added explanation for what a OSD is
> * Added explanation of the color parameter
> * Moved GDSYS_LEGACY_OSD_CMDS to gdsys Kconfig
>
> ---
>  board/gdsys/mpc8308/Kconfig |  11 ++
>  cmd/Kconfig                 |   8 +
>  cmd/Makefile                |   1 +
>  cmd/osd.c                   | 378 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 398 insertions(+)
>  create mode 100644 cmd/osd.c

To me it seems unfortunate that the legacy and new commands are named
the same. I suppose that is unavoidable?

I wonder if the legacy code could be moved to board/gdsys instead? It
is out of the way then.

Regards,
Simon


More information about the U-Boot mailing list