[U-Boot] [PATCH 1/4] sound: Correct data output in sound_create_square_wave()

Simon Glass sjg at chromium.org
Fri Nov 16 02:56:12 UTC 2018


This function currently outputs twice as much data as it should and
overwrites its buffer as a result. Fix it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 drivers/sound/sound.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/sound/sound.c b/drivers/sound/sound.c
index 969408186fd..6c1eb4c19cc 100644
--- a/drivers/sound/sound.c
+++ b/drivers/sound/sound.c
@@ -25,12 +25,10 @@ void sound_create_square_wave(unsigned short *data, int size, uint32_t freq)
 		for (i = 0; size && i < half; i++) {
 			size -= 2;
 			*data++ = amplitude;
-			*data++ = amplitude;
 		}
 		for (i = 0; size && i < period - half; i++) {
 			size -= 2;
 			*data++ = -amplitude;
-			*data++ = -amplitude;
 		}
 	}
 }
-- 
2.19.1.1215.g8438c0b245-goog



More information about the U-Boot mailing list