[U-Boot] [PATCH 03/15] rockchip: rk3288: Print reset reason

Kever Yang kever.yang at rock-chips.com
Mon Aug 5 12:30:21 UTC 2019


On 2019/7/29 下午3:46, Jagan Teki wrote:
> Print the reason for reset instead of storing it into
> env variable in rk3288.
>
> This would help to find the reset reason directly
> on U-Boot proper logs.
>
> Cc: Wadim Egorov <w.egorov at phytec.de>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> ---
>   arch/arm/mach-rockchip/rk3288-board.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c
> index d3ec141fea..613264d7ee 100644
> --- a/arch/arm/mach-rockchip/rk3288-board.c
> +++ b/arch/arm/mach-rockchip/rk3288-board.c
> @@ -72,7 +72,7 @@ static void rk3288_detect_reset_reason(void)
>   		reason = "unknown reset";
>   	}
>   
> -	env_set("reset_reason", reason);
> +	printf("Reset cause: %s\n", reason);


Why this need to set as env before? I didn't touch this code when I migrate

the code to use common board file. If this no need to set env, then this

call back can goto board_init() instead of board_late_init().


Thanks,

- Kever

>   
>   	/*
>   	 * Clear cru_glb_rst_st, so we can determine the last reset cause




More information about the U-Boot mailing list