[U-Boot] [PATCH v1 05/14] board: cosmetic: Use define to set ENET clock selection mask on TPC70

Marek Vasut marex at denx.de
Wed Jan 2 14:12:43 UTC 2019


On 1/2/19 11:06 AM, Lukasz Majewski wrote:
> Hi Marek,
> 
>> On 1/2/19 12:37 AM, Lukasz Majewski wrote:
>>> This is a cosmetic change, just to use proper define.
>>>
>>> Signed-off-by: Lukasz Majewski <lukma at denx.de>  
>>
>> The subject tags are wrong, fix globally.
> 
> Is there any doc which describes the allowed/not allowed tags (either
> with Linux or U-boot)? 

I am not aware of one, however you can write one if you feel inclined to
do so.

> From my experience it is a some kind of a convention depending on the
> maintainer (which helps him to spot relevant patches on ML).

Right, and this is ARM imx board, hence those tags should be included.

> In [1] - point 14) there is:
> The canonical patch subject line is:
> "Subject: [PATCH 001/123] subsystem: summary phrase"
> 
> and the "subsystem: " is the tag. 
> 
> In the case of this patch -> I do fix stuff in "board(s)" which is
> "cosmetic".
> 
> Or will we only stick to tags/mails from ./doc/git-mailrc ?
> 
> [1] -
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

[...]

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list