[U-Boot] [PATCH v4 06/13] clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)

Stefano Babic sbabic at denx.de
Sat Jun 8 15:23:36 UTC 2019



On 17/05/19 00:10, Lukasz Majewski wrote:
> Up till now the fixed rate clock ('osc') has been added to UCLASS_CLK
> without declaring struct clk. As a result it was only accessible by
> iterating the udevice's uclass list.
> 
> This is a problem for clock code, which operates on pointers to struct
> clk (like clk_get_rate()), not udevices.
> 
> After this change struct clk is accessible from udevice and udevice from
> struct clk.
> 
> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> 
> ---
> 
> Changes in v4:
> - None
> 
> Changes in v3: None
> 
>  drivers/clk/clk_fixed_rate.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/clk/clk_fixed_rate.c b/drivers/clk/clk_fixed_rate.c
> index 50dbb13655..089f060a23 100644
> --- a/drivers/clk/clk_fixed_rate.c
> +++ b/drivers/clk/clk_fixed_rate.c
> @@ -8,6 +8,7 @@
>  #include <dm.h>
>  
>  struct clk_fixed_rate {
> +	struct clk clk;
>  	unsigned long fixed_rate;
>  };
>  
> @@ -24,10 +25,14 @@ const struct clk_ops clk_fixed_rate_ops = {
>  
>  static int clk_fixed_rate_ofdata_to_platdata(struct udevice *dev)
>  {
> +	struct clk *clk = &to_clk_fixed_rate(dev)->clk;
>  #if !CONFIG_IS_ENABLED(OF_PLATDATA)
>  	to_clk_fixed_rate(dev)->fixed_rate =
>  		dev_read_u32_default(dev, "clock-frequency", 0);
>  #endif
> +	/* Make fixed rate clock accessible from higher level struct clk */
> +	dev->driver_data = (ulong)clk;
> +	clk->dev = dev;
>  
>  	return 0;
>  }
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic
-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list