[U-Boot] [PATCH] pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Eugeniu Rosca erosca at de.adit-jv.com
Wed Jun 19 14:18:43 UTC 2019


Hi Jeremy,

On Wed, Jun 19, 2019 at 08:05:10AM +0800, Jeremy Kerr wrote:
> Hi Eugeniu,
> 
> > Replicating the chronology of the issue, do you think it could be
> > related to 1) the patch size or to 2) the moderator's approval event?
> > 
> >   +--------------+
> >   |1. Patch sent |
> >   +------+-------+
> >          |   
> >   +------v----------------------------------------+
> >   |2. U-Boot reports awaiting moderator's approval|
> >   |   (the patch does not show up in patchwork)   |
> >   +------+----------------------------------------+
> >          |   
> >   +------v-------------------------------+
> >   |3. Reply A (not rendered by patchwork)|
> >   +------+-------------------------------+
> >          |   
> >   +------v-------------------------------+
> >   |4. Reply B (not rendered by patchwork)|
> >   +------+-------------------------------+
> >          |   
> >   +------v-----------------------------+
> >   |5. Patch approved by moderator      |
> >   |   (the patch shows up in patchwork)|
> >   +------+-----------------------------+
> >          |   
> >   +------v---------------------------+
> >   |6. Reply C (rendered by patchwork)|
> >   +------+---------------------------+
> >          |
> >   +------v---------------------------+
> >   |7. Reply D (rendered by patchwork)|
> >   +----------------------------------+
> 
> Ah, that would explain it. If an incoming email is not a patch, then
> patchwork will assume it is a follow-up to a patch, and try to find the
> relevant patch (through the References: and In-Reply-To headers). If no
> suitable patch is found, then patchwork does not save the email.
> 
> It sounds like that's what's happening here. Since reply A and reply B
> are referencing a patch that does not (yet) exist, then the comments are
> not kept.

To be honest, that sounds like sensible behavior, but I wonder how
marc.info (and presumably other front-ends) achieve to still display
the replies sent/received at a point in time when the original patch is
still expecting moderator's Ack.

> The alternative would be to keep *every* submission to the list, in case
> a relevant patch arrives later...

Seems like this or similar solution is employed by https://marc.info/ ?
My 2 cents is that it is more user-friendly and would definitely
improve the patchwork as a tool if it displayed any replies which were
submitted between the push of the original patch and the moderator's Ack
of the latter.

-- 
Best Regards,
Eugeniu.


More information about the U-Boot mailing list