[U-Boot] [RFC] simple address definition method for early TPL/SPL

Kever Yang kever.yang at rock-chips.com
Fri Mar 29 14:52:46 UTC 2019



On 03/29/2019 09:02 AM, Kever Yang wrote:
>
> Here are the solutions from previous discussion:
> - dts (by Simon)
>     extra dtb code needed, setting separate into individual board dts;
>     not available and not suggestion to use in TPL/SPL;
> - move to header in 'asm/arch-rockchip' (by Philipp)
>     one more place to config, make config options more complicate;
>     may separate in more than 10+ files for different soc/board;
> - RMII setting like, (by Philipp)
>     reference to 'drivers/net/gmac_rockchip.c', driver for different
> SoCs are not re-usable, driver needs to update for each new SoC support;
>     not available with DM in early TPL/SPL;
> - Kconfig with default value in this patch
>     Keep driver clean and no need to update with new SoC;
>     One place rather than 10+ individual files, same usage like
> SYS_TEXT_BASE, reference to:
>       341c058654 sunxi: move CONFIG_SYS_TEXT_BASE out of defconfigs

If you are not happy with the format which all soc reg address defined
in the same place, one more solution:
How about using the format like TPL_TEXT_BASE followed by each SoC and
system will report error if not defined:
140 if
ROCKCHIP_RK3368                                                             

141                                                                                

142 config
TPL_TEXT_BASE                                                           
143         default
0xff8c1000                                                     
144                                                                                

145 config
TPL_MAX_SIZE                                                            
146         default
28672                                                          
147                                                                                                                                          

148 config
TPL_STACK                                                               
149         default
0xff8cffff                                                     
150                                                                                

151 endif 

Thanks,
- Kever




More information about the U-Boot mailing list