[U-Boot] [PATCH] imx8mq_evk: Staticize when appropriate

Peng Fan peng.fan at nxp.com
Mon May 20 01:41:14 UTC 2019


> Subject: [PATCH] imx8mq_evk: Staticize when appropriate
> 
> Staticize 'spl_dram_init' and 'i2c_pad_info1' to fix the following sparse
> warnings:
> 
> board/freescale/imx8mq_evk/spl.c:30:6: warning: symbol 'spl_dram_init' was
> not declared. Should it be static?
> board/freescale/imx8mq_evk/spl.c:41:22: warning: symbol 'i2c_pad_info1'
> was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  board/freescale/imx8mq_evk/spl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/freescale/imx8mq_evk/spl.c
> b/board/freescale/imx8mq_evk/spl.c
> index e6cbc34b0d..3c0ff0bb1b 100644
> --- a/board/freescale/imx8mq_evk/spl.c
> +++ b/board/freescale/imx8mq_evk/spl.c
> @@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR;
> 
>  extern struct dram_timing_info dram_timing_b0;
> 
> -void spl_dram_init(void)
> +static void spl_dram_init(void)
>  {
>  	/* ddr init */
>  	if ((get_cpu_rev() & 0xfff) == CHIP_REV_2_1) @@ -38,7 +38,7 @@ void
> spl_dram_init(void)
> 
>  #define I2C_PAD_CTRL	(PAD_CTL_DSE6 | PAD_CTL_HYS |
> PAD_CTL_PUE)
>  #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
> -struct i2c_pads_info i2c_pad_info1 = {
> +static struct i2c_pads_info i2c_pad_info1 = {
>  	.scl = {
>  		.i2c_mode = IMX8MQ_PAD_I2C1_SCL__I2C1_SCL | PC,
>  		.gpio_mode = IMX8MQ_PAD_I2C1_SCL__GPIO5_IO14 | PC,

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> --
> 2.17.1



More information about the U-Boot mailing list