[U-Boot] [PATCH v3 061/108] x86: fsp: Make the notify API call common

[Bin Meng]

On Mon, Oct 21, 2019 at 11:40 AM Simon Glass <sjg at chromium.org> wrote:
>
> The fsp_notify() API is the same for FSP1 and FSP2. Move it into a new
> common API file.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/x86/include/asm/fsp/fsp_api.h  | 27 +++++++++++++++++++++++++++
>  arch/x86/include/asm/fsp1/fsp_api.h | 21 +++------------------
>  2 files changed, 30 insertions(+), 18 deletions(-)
>  create mode 100644 arch/x86/include/asm/fsp/fsp_api.h
>
> diff --git a/arch/x86/include/asm/fsp/fsp_api.h b/arch/x86/include/asm/fsp/fsp_api.h
> new file mode 100644
> index 00000000000..541f86ff0e8
> --- /dev/null
> +++ b/arch/x86/include/asm/fsp/fsp_api.h
> @@ -0,0 +1,27 @@
> +/* SPDX-License-Identifier: Intel */
> +/*
> + * Copyright (C) 2015-2016 Intel Corp.
> + * (Written by Andrey Petrov <andrey.petrov at intel.com> for Intel Corp.)
> + * (Written by Alexandru Gagniuc <alexandrux.gagniuc at intel.com> for Intel Corp.)
> + * Mostly taken from coreboot fsp2_0/memory_init.c

nits: is this really from coreboot fsp2_0/memory_init.c?

> + */
> +
> +#ifndef __ASM_FSP_API_H
> +#define __ASM_FSP_API_H
> +
> +enum fsp_phase {
> +       /* Notification code for post PCI enuermation */
> +       INIT_PHASE_PCI  = 0x20,
> +       /* Notification code before transferring control to the payload */
> +       INIT_PHASE_BOOT = 0x40
> +};
> +
> +struct fsp_notify_params {
> +       /* Notification phase used for NotifyPhase API */
> +       enum fsp_phase  phase;
> +};
> +
> +/* FspNotify API function prototype */
> +typedef asmlinkage u32 (*fsp_notify_f)(struct fsp_notify_params *params);
> +
> +#endif

[snip]

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>