[U-Boot] [PATCH v5 17/26] configs: socfpga: mcvevk: Remove useless UBI infos

Wolfgang Grandegger wg at aries-embedded.de
Mon Nov 25 11:53:22 UTC 2019


Hello,

Am 24.11.19 um 16:13 schrieb Tom Rini:
> On Thu, Oct 03, 2019 at 07:50:19PM +0200, Miquel Raynal wrote:
> 
>> There is no flash on this board, there is no reason to define MTD
>> environment variables nor UBI. Drop them from the configuration file.
>>
>> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
>> ---
>>  configs/socfpga_mcvevk_defconfig | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/configs/socfpga_mcvevk_defconfig b/configs/socfpga_mcvevk_defconfig
>> index 39cc753888..15c9f7fdb0 100644
>> --- a/configs/socfpga_mcvevk_defconfig
>> +++ b/configs/socfpga_mcvevk_defconfig
>> @@ -28,9 +28,6 @@ CONFIG_CMD_USB=y
>>  CONFIG_CMD_USB_MASS_STORAGE=y
>>  CONFIG_CMD_CACHE=y
>>  CONFIG_CMD_EXT4_WRITE=y
>> -CONFIG_MTDIDS_DEFAULT="nor0=ff705000.spi.0"
>> -CONFIG_MTDPARTS_DEFAULT="mtdparts=ff705000.spi.0:1m(u-boot),256k(env1),256k(env2),14848k(boot),16m(rootfs),- at 1536k(UBI)0"
>> -CONFIG_CMD_UBI=y
>>  # CONFIG_ISO_PARTITION is not set
>>  # CONFIG_EFI_PARTITION is not set
>>  CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_mcvevk"
> 
> This board has SPI flash and so the MTDIDS/PARTS make sense there.  I'm
> adding in the board maintainer for further comment about how UBI might
> be used, thanks!

There is *no* SPI-FLash connected to the HPS on that module/board.
Therefore these options can safely be removed. (There is a SPI-NOR
connected to the FPGA for configuration purposes).

Miquel, feel free to add my:

  Reviewed-by: Wolfgang Grandegger <wg at aries-embedded.de>

Thanks,

Wolfgang

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191125/a453614d/attachment.sig>


More information about the U-Boot mailing list