[U-Boot] [PATCH v2 2/2] drivers: usb: host: Add BRCM xHCI driver

Vladimir Olovyannikov vladimir.olovyannikov at broadcom.com
Tue Nov 26 18:36:59 UTC 2019


> -----Original Message-----
> From: Marek Vasut <marex at denx.de>
> Sent: Tuesday, November 26, 2019 10:22 AM
[...]
> On 11/26/19 7:18 PM, Vladimir Olovyannikov wrote:
> [...]
> > +	/* Enable AXI read and write attributes. */
> > +	clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIWRA),
>
> Here is another extra parenthesis ;-)
>
> > +			(USBAXIWR_UA_MASK | USBAXIWR_SA_MASK),
> > +			(USBAXIWR_UA_VAL | USBAXIWR_SA_VAL));
> > +	clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIRDA),
> > +			(USBAXIRD_UA_MASK | USBAXIRD_SA_MASK),
> > +			(USBAXIRD_UA_VAL | USBAXIRD_SA_VAL));
>
> There is a lot of them ^ Please fix those, otherwise it's good.
Thanks for the catch. Will be addressed in patch v3.
>
> [..]


More information about the U-Boot mailing list