Aw: Re: [PATCH v2 09/11] arm: dts: mt7622: add sata- and asm_sel nodes

[Chunfeng Yun]

On Wed, 2020-08-19 at 12:58 +0200, Frank Wunderlich wrote:
> Hi
> 
> > Gesendet: Mittwoch, 19. August 2020 um 10:54 Uhr
> > Von: "Chunfeng Yun" <chunfeng.yun at mediatek.com>
> > > +	sata_phy: sata-phy at 1a243000 {
> > > +		compatible = "mediatek,generic-tphy-v1";
> > > +		#address-cells = <1>;
> > > +		#size-cells = <1>;
> > > +		ranges;
> > we can use ranges with parameters if you send next version, otherwise no
> > change is also fine to me.
> >
> > ranges=<0 0x1a243000 0x100>;
> 
> i took the dts-part from linux where ranges is also empty
> 
> https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/mediatek/mt7622.dtsi#L880
> 
I think it follows the early dt-binding doc of tphy, I modify it later.

> why should ranges have a value when i recently removed the reg (after making it optional)?
Both are ok, but prefer to use translation way:)

Without shared registers, it's simple and clear to use address
translation from parent-bus-address to child-bus-address. 
e.g. subnode: usb-phy at 0, usb-phy at 1000, they tell us the offset at the
same time.

> 
> > For phy part,
> > Reviewed-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> 
> any issues in sata-node/gpio-hog?
Also looks good to me

> 
> regards Frank