[PATCH v2] common: update: fix an "unused" warning against update_flash()

Tom Rini trini at konsulko.com
Thu Dec 3 17:59:05 CET 2020


On Thu, Nov 19, 2020 at 09:37:19AM +0900, AKASHI Takahiro wrote:

> Since update_flash() is used only in update_tftp(), it should be
> guarded with appropriate config options.
> 
> After the commit 3149e524fc1e, common/update.c will be built under
> either CONFIG_UDATE_TFTP, CONFIG_DFU_TFTP or CONFIG_UPDATE_FIT.
> Since CONFIG_UPDATE_FIT, hence fit_update(), doesn't rely on
> update_flash(), the compiler may cause an "unused" warning if
> CONFIG_UPDATE_FIT=y and CONFIG_UPDATE_TFTP=n and CONFIG_DFU_TFTP=n.
> 
> This is, for example, the case for sandbox defconfig where
> EFI_CAPSULE_FIRMWARE_FIT is enabled for test purpose.
> 
> Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
>        image")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201203/8a90c42e/attachment.sig>


More information about the U-Boot mailing list