[PATCH v3 02/15] arm: cpu: armv8: add L3 memory flush support

[Rayagonda Kokatanur]

Hi Simon,

On Fri, Jun 26, 2020 at 7:13 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Rayagonda,
>
> On Fri, 19 Jun 2020 at 10:55, Rayagonda Kokatanur
> <rayagonda.kokatanur at broadcom.com> wrote:
> >
> > Hi Simon,
> >
> > On Wed, Jun 17, 2020 at 8:42 AM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > On Wed, 10 Jun 2020 at 04:41, Rayagonda Kokatanur
> > > <rayagonda.kokatanur at broadcom.com> wrote:
> > > >
> > > > Add L3 memory flush support for NS3.
> > > >
> > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
> > > > ---
> > > >  arch/arm/cpu/armv8/Makefile          |  1 +
> > > >  arch/arm/cpu/armv8/bcmns3/Makefile   |  5 ++
> > > >  arch/arm/cpu/armv8/bcmns3/lowlevel.S | 90 ++++++++++++++++++++++++++++
> > > >  3 files changed, 96 insertions(+)
> > > >  create mode 100644 arch/arm/cpu/armv8/bcmns3/Makefile
> > > >  create mode 100644 arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > >
> > > > diff --git a/arch/arm/cpu/armv8/Makefile b/arch/arm/cpu/armv8/Makefile
> > > > index 2e48df0eb9..7e33a183d5 100644
> > > > --- a/arch/arm/cpu/armv8/Makefile
> > > > +++ b/arch/arm/cpu/armv8/Makefile
> > > > @@ -39,3 +39,4 @@ obj-$(CONFIG_S32V234) += s32v234/
> > > >  obj-$(CONFIG_TARGET_HIKEY) += hisilicon/
> > > >  obj-$(CONFIG_ARMV8_PSCI) += psci.o
> > > >  obj-$(CONFIG_ARCH_SUNXI) += lowlevel_init.o
> > > > +obj-$(CONFIG_TARGET_BCMNS3) += bcmns3/
> > > > diff --git a/arch/arm/cpu/armv8/bcmns3/Makefile b/arch/arm/cpu/armv8/bcmns3/Makefile
> > > > new file mode 100644
> > > > index 0000000000..a35e29d11a
> > > > --- /dev/null
> > > > +++ b/arch/arm/cpu/armv8/bcmns3/Makefile
> > > > @@ -0,0 +1,5 @@
> > > > +# SPDX-License-Identifier: GPL-2.0+
> > > > +#
> > > > +# Copyright 2020 Broadcom.
> > > > +
> > > > +obj-y  += lowlevel.o
> > > > diff --git a/arch/arm/cpu/armv8/bcmns3/lowlevel.S b/arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > > new file mode 100644
> > > > index 0000000000..202286248e
> > > > --- /dev/null
> > > > +++ b/arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > > @@ -0,0 +1,90 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > > > +/*
> > > > + * Copyright 2020 Broadcom
> > > > + *
> > > > + * Extracted from fsl-layerscape/lowlevel.S
> > >
> > > Should this file be common, then? Is the (c) correct?
> >
> > Do you mean, file "arch/arm/cpu/armv8/bcmns3/lowlevel.S" should be
> > common and for common file copyright tag should be "(C) Copyright
> > 2020"  instead of "Copyright 2020 Broadcom".
> >
>
> The comment suggests it was copied from another file, in which case
> you should keep the (c) from that file, perhaps adding your own.
>
> But if the two files are the same, can you just have one file and move
> it to a common location?

The comment is misleading.
Though it is copied from another file but both files are not same.
Let me remove that comment.

Thank you,
Rayagonda

>
> > Please let me know.
>
> Consider yourself let.
>
> Regards,
> Simon