[PATCH 2/2] configs: socfpga: Add QSPI boot for Arria 10 SoCDK

[Marek Vasut]

On 3/2/20 10:33 AM, Ley Foon Tan wrote:
> On Fri, Feb 21, 2020 at 9:25 AM Ley Foon Tan <ley.foon.tan at intel.com> wrote:
>>
>> Add QSPI boot settings for Arria 10 SoCDK.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
>> ---
>>  include/configs/socfpga_arria10_socdk.h | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/include/configs/socfpga_arria10_socdk.h b/include/configs/socfpga_arria10_socdk.h
>> index 645e66e6b0..e1d01c095f 100644
>> --- a/include/configs/socfpga_arria10_socdk.h
>> +++ b/include/configs/socfpga_arria10_socdk.h
>> @@ -39,6 +39,15 @@
>>  /* SPL memory allocation configuration, this is for FAT implementation */
>>  #define CONFIG_SYS_SPL_MALLOC_SIZE     0x00015000
>>
>> +#define KERNEL_FIT_ADDR                __stringify(0x1200000)
>> +
>> +#define SOCFPGA_BOOT_SETTINGS \
>> +       "kernelfit_addr=" KERNEL_FIT_ADDR "\0" \
>> +       "qspiboot=setenv bootargs " CONFIG_BOOTARGS \
>> +                       "root=/dev/mtdblock1 rw rootfstype=jffs2;" \
>> +                       "bootm ${scriptaddr}\0" \
>> +       "qspiload=sf probe; sf read ${scriptaddr} ${kernelfit_addr}\0" \
>> +
>>  /* The rest of the configuration is shared */
>>  #include <configs/socfpga_common.h>
>>
> 
> Any comment on this patch?

Can we get rid of rootfstype=jffs2 ? It's archaic and you can use UBI on
top of SPI NOR too. Also, isn't there already some kernel_addr_r for the
kernel address ?

Finally, can't we switch to distro boot command on socfpga, to handle
all the various devices ?