[PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

[Stefan Roese]

On 16.08.21 15:01, Marek Behún wrote:
> On Mon, 16 Aug 2021 14:50:15 +0200
> Stefan Roese <sr at denx.de> wrote:
> 
>>> -	disable_mcu_watchdog();
>>> +	/*
>>> +	 * If not booting from UART, MCU watchdog was not disabled
>>> in SPL,
>>> +	 * disable it now.
>>> +	 */
>>> +	if (get_boot_device() != BOOT_DEVICE_UART)
>>> +		disable_mcu_watchdog();
>>
>> Why do you disable the MCU watchdog here in U-Boot proper?
> 
> Hi Stefan,
> 
> this is just where it was before.
> But looking at the prompt
>     SoC:   MV88F6820-A0 at 1600 MHz
>     DRAM:  2 GiB (800 MHz, 32-bit, 2T, ECC not enabled)
>     Disabling MCU watchdog... disabled
>     WDT:   Started with servicing (60s timeout)
> 
> it looks like U-Boot's watchdog is being enabled after MCU watchdog.
> It would be better to enable U-Boot's WDT before disabling MCU watchdog.
> I will send another patch that moves it to another function,
> board_late_init for example.

So the MCU watchdog is some kind of very early WD and only used until
the SoC WD is used / enabled?

> Shall I resend this series with this new patch?

Yes, please do.

Thanks,
Stefan