[PATCH 5/5] ds414: Add sample u-boot update command

Phil Sutter phil at nwl.cc
Thu Mar 4 14:56:12 CET 2021


On Thu, Mar 04, 2021 at 02:34:53PM +0100, Stefan Roese wrote:
> On 04.03.21 14:28, Phil Sutter wrote:
> > On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote:
> >> On 03.03.21 01:55, Phil Sutter wrote:
> >>> Signed-off-by: Phil Sutter <phil at nwl.cc>
> >>
> >> It's common practice to add some minimal text in the commit text,
> >> even for simple patches.
> > 
> > I should learn to put less meaningful subjects in those cases so I have
> > an easier time finding something to write about in the description.
> 
> ;)
> 
> > Then
> > again, your question indicates I just didn't think hard enough.
> 
> I agree that this "rule" is sometimes hard to understand. I myself
> am sometimes finding it stupid to write the same sentence twice.

I've seen enough projects where one-liners are absolutely acceptable,
I'd rather write redundant texts than accepting that coding "style".
Nothing worse than confusing code garnished with no description at all.
:)

[...]
> > BTW: I spent a while trying to make the DTB-defined partitions available
> > in sf command, but eventually gave up. Seems I need to have this
> > SPI->MTD mapping and still define partitions in environment. Not worth
> > spending cycles on though, I was just curious because 'help sf' mentions
> > partitions as offset alternatives.
> 
> Not looking to hard into your issue here, but did you take a look at
> the "mtd" command? It's newer than the other flash related commands
> and can manage all kind of flash types (SPI NOR, NAND etc) in one
> place. And also integrated better into the MTD partitions IIRC.

Hmm, for some reason I assumed 'sf' is the optimal tool for SPI flashes.
I'll give it a try, thanks for the hint!

Thanks, Phil


More information about the U-Boot mailing list