[PATCH] acpi: Use U-Boot version for OEM_REVISION

Pali Rohár pali at kernel.org
Wed Oct 6 14:19:06 CEST 2021


On Thursday 30 September 2021 13:46:31 Tom Rini wrote:
> On Wed, Sep 29, 2021 at 10:08:58PM -0600, Simon Glass wrote:
> > Hi Pali,
> > 
> > On Sun, 12 Sept 2021 at 15:30, Pali Rohár <pali at kernel.org> wrote:
> > >
> > > On Tuesday 20 July 2021 12:32:46 Simon Glass wrote:
> > > > On Sat, 10 Jul 2021 at 05:10, Pali Rohár <pali at kernel.org> wrote:
> > > > >
> > > > > OEM_REVISION is 32-bit unsigned number. It should be increased only when
> > > > > changing software version. Therefore it should not depend on build time.
> > > > >
> > > > > Change calculation to use U-Boot version numbers and set this revision
> > > > > to date number.
> > > > >
> > > > > Prior this change OEM_REVISION was calculated from build date and stored in
> > > > > the same format.
> > > > >
> > > > > After this change macro U_BOOT_BUILD_DATE is not used in other files so
> > > > > remove it from global autogenerated files and also from Makefile.
> > > > >
> > > > > Signed-off-by: Pali Rohár <pali at kernel.org>
> > > > > ---
> > > > > This patch depends on similar patch for BIOS Release Date which is here:
> > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210422160957.26936-1-pali@kernel.org/
> > > > > ---
> > > > >  Makefile                |  2 --
> > > > >  doc/develop/version.rst |  1 -
> > > > >  lib/acpi/acpi_table.c   | 18 +++++++++++++++++-
> > > > >  test/dm/acpi.c          | 20 ++++++++++++++------
> > > > >  4 files changed, 31 insertions(+), 10 deletions(-)
> > > >
> > > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > >
> > > Hello! Could you process this patch? Or are there any issues?
> > 
> > +Tom Rini
> > 
> > It isn't in my queue. Perhaps Tom has it?
> 
> Well, hunh.  I don't know when I moved it to Accepted, but it clearly
> wasn't.  Sorry about that.

Ok, so could be this patch accepted?


More information about the U-Boot mailing list